Repository navigation
Conversation
Check also for integer overflow in _PyType_AllocNoTrack(). Remove redundant (and incomplete) integer overflow from tuple_alloc() and _PyTuple_Resize().
Member
Author
|
I wrote a first PR #161908 to detect integer overflow in PyObject_GC_NewVar() and PyObject_GC_Resize(). Then I searched for
So instead of changing PyObject_GC_NewVar() and PyObject_GC_Resize(), I wrote this PR which is more generic to change |
In debug mode, check also that nitems >= 0 in _PyType_AllocNoTrack() and _PyObject_GC_Resize().
Fix compiler warning:
Include/cpython/objimpl.h:31:5: error: ISO C90 forbids mixed
declarations and code [-Werror=declaration-after-statement]
Don't compute nitems * itemsize if tp_itemsize is zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check also for integer overflow in _PyType_AllocNoTrack().
Remove redundant (and incomplete) integer overflow from tuple_alloc() and _PyTuple_Resize().
PyTupleWriterAPI #161694