Repository navigation
gh-126253: Ignore unknown Windows file attribute bits in scandir test - #156305
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit 744f998 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156305%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
… NEWS Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This reverts commit e29f458.
|
!buildbot ARM64 Windows( Non-Debug)? PR |
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit 6928e67 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156305%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I pushed a change to add a comment on FILE_ATTRIBUTE_MASK.
|
Let me enable auto-merge, #126253 issue is failing for several days on ARM64 Windows buildbots, it's quite annoying. |
|
#126253 fails also on 3.14 and 3.15 buildbots, so I enabled backport to these branches. |
| @@ -0,0 +1 @@ | |||
| Fix ``test_os.test_attributes()`` on Windows NTFS: ignore unknown file attributes. | |||
There was a problem hiding this comment.
I'm not convinced this needs a NEWS entry at all.
There was a problem hiding this comment.
The issue #126253 is failing for at least 2 years, IMO it's ok to document the fix. At the beginning, the NEWS entry was way longer, Hugo rewrote it to make it shorter.
Anyway, your comment was posted after I enabled auto-merge and the change was just merged with the NEWS entry in the meanwhile. Sorry! So I will just backport it as it is.
There was a problem hiding this comment.
(My shortening was applying Victor's suggestion :)
|
GH-161899 is a backport of this pull request to the 3.15 branch. |
|
GH-161900 is a backport of this pull request to the 3.14 branch. |
|
GH-162043 is a backport of this pull request to the 3.13 branch. |
For #126253.
os.scandir().stat()andos.stat()can return different values forst_file_attributeswhen NTFS reports bits that are not exposed by Python'sstatmodule. Limit the scandir test comparison to the publicstat.FILE_ATTRIBUTE_*bits, while continuing to compare every public bit strictly.The regression test constructs
os.stat_resultvalues with the reported0x10000000bit so the behavior is covered even on Windows builds where the filesystem does not naturally return it. It also verifies that a difference inFILE_ATTRIBUTE_READONLYstill fails the comparison.Tests:
PCbuild\amd64\python_d.exe -m test test_os.test_os -m "*attributes*" -vPCbuild\amd64\python_d.exe -m test -v test_osPCbuild\amd64\python_d.exe Tools\patchcheck\patchcheck.pyThis contribution was prepared with assistance from OpenAI Codex. I reviewed and tested the resulting changes.
test_os.test_attributes()fails on Windows #126253