Repository navigation
Conversation
savannahostrowski
left a comment
Member
There was a problem hiding this comment.
Hmmm, I’m trying to understand where reuse happens in practice, though. The standard workflows use actions/checkout with cleanup enabled by default, and I can see it removing cpython/, pyperformance/, and pyston-benchmarks/ in my runner logs at the start of each job. Is there a particular workflow where you’re seeing unnecessary re-cloning?
Contributor
Author
|
@savannahostrowski Not really, found through code inspection, not runner logs. Fine to close if you want! |
# Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git.clone()currently compares a full commit SHA with the abbreviated hash returned byget_git_hash(). This causes an existing checkout at the requested commit to be deleted and cloned again. The PR compares the full SHA instead and adds a regression test.