Repository navigation
test: deflake test-fs-stat-cancel-inflight under FIPS - #67449
Open
christianaurichzm wants to merge 1 commit into
Open
christianaurichzm wants to merge 1 commit into
christianaurichzm wants to merge 1 commit into
Conversation
The pbkdf2() call that keeps the only threadpool worker busy used a 6-byte password and a 4-byte salt. OpenSSL 4 FIPS rejects those, so the derivation failed at once and freed the worker. The queued stat could then start before req.cancel() ran, and it completed without ECANCELED. Use inputs that meet the FIPS minimums and check that the derivation succeeds. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67449 +/- ##
==========================================
- Coverage 90.71% 90.69% -0.02%
==========================================
Files 801 801
Lines 281889 281889
Branches 54315 54316 +1
==========================================
- Hits 255709 255669 -40
- Misses 16307 16353 +46
+ Partials 9873 9867 -6 🚀 New features to boost your workflow:
|
panva
approved these changes
Nov 13, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-fs-stat-cancel-inflightfails in 4 of the last 44 runs of theopenssl-fips-4.1.0job in "Test Shared libraries", most recently onmain: https://github.com/nodejs/node/actions/runs/43344160379/job/131620075895The
pbkdf2()that keeps the only threadpool worker busy uses a 6-byte password and a 4-byte salt, which OpenSSL 4 FIPS rejects. The derivation fails at once, and the freed worker sometimes starts the stat beforereq.cancel()runs. This switches to inputs that meet the FIPS minimums and usescommon.mustSucceed(), so a rejected derivation fails the test instead of turning it flaky.With a blocker that finishes immediately the test fails 2/1000 locally, and with this change 0/1000.
Refs: #67248