Repository navigation
quic: fix h3 session close on early stream destroy - #67446
Open
Ethan-Arrowood wants to merge 1 commit into
Open
Ethan-Arrowood wants to merge 1 commit into
Ethan-Arrowood wants to merge 1 commit into
Conversation
If the stream is destroyed right after sendHeaders(), nghttp3 still has the response headers queued. On the next write it asks for the removed stream's body, the read callback fails, and the whole session closes without notifying the peer. In an HTTP/3 session, before clearing nghttp3's pointer to a stream when the stream is destroyed, shut down nghttp3's writes for that stream so that other requests can continue to complete. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67446 +/- ##
==========================================
- Coverage 90.68% 90.68% -0.01%
==========================================
Files 801 801
Lines 281889 281889
Branches 54318 54319 +1
==========================================
- Hits 255645 255641 -4
- Misses 16358 16360 +2
- Partials 9886 9888 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the stream is destroyed right after sendHeaders(), nghttp3 still has the response headers queued. On the next write it asks for the removed stream's body, the read callback fails, and the whole session closes without notifying the peer.
In an HTTP/3 session, before clearing nghttp3's pointer to a stream when the stream is destroyed, shut down nghttp3's writes for that stream so that other requests can continue to complete.
This PR adds regression tests to cover the issue.
Discovered this while reviewing #66007, which adds
stream.cancel(). That PR's cancel-after-headers case depends on this fix. Callingdestroy()without a code still sends no reset, which is out of scope here (continue discussion in #66007).AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.