Repository navigation
Conversation
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65890 +/- ##
========================================
Coverage 90.73% 90.74%
========================================
Files 798 798
Lines 280017 280222 +205
Branches 53860 53918 +58
========================================
+ Hits 254076 254275 +199
- Misses 16235 16237 +2
- Partials 9706 9710 +4
🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 Yes I do, let me fix that, and the branch conflict. |
2b1b0d8 to
9d81459
Compare
Signed-off-by: Luciano Leggieri <230980@gmail.com> Assisted-by: Sol 5.6
9d81459 to
fc2098e
Compare
|
@MikeMcC399 I have addressed the commit message issues. |
Thank you! |
|
@jasnell sorry to bother you. You approved this Pull Request previously, and I lost it because I have to fix the commit message. May I ask you to review again? |
I'm splitting my previous PR into smaller chunks, hoping the changes are easier to understand.
This one modifies the following iterator helpers:
forEach()some()every()find()Please see my previous PR that contains screenshots of benchmarks showcasing the performance improvements in this proposal.
Note that
someandeveryused to depend onfilterbut they now depend onfind.In terms of the logic inside
operators.js, it's not easy to view these changes as a diff because the previous logic almost entirely relied oncreateAsyncIterator, which is in a different file (readable.js) and the asynchronous iteration engine that v8 provides. The new proposal is an implementation from scratch that keeps the same compatibility evaluated by the tests, but with improved performance. It's better to consider both as black box implementations rather than trying to diff.