Skip to content

build: use call command when calling python - #60098

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ZenMasterJacob20011:vcbuild.bat-not-finishing
Oct 21, 2025
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ZenMasterJacob20011:vcbuild.bat-not-finishing

Conversation

@ZenMasterJacob20011

Copy link
Copy Markdown
Contributor

When running .\vcbuild.bat in PowerShell the file is stopping execution after calling python configure %configure_flags% even if python configure exits with a status of 0. Because the commands after python configure %configure_flags% are never called you don't finish building and thus never get a out or release folder with node.exe in it.
I am currently developing on Windows 10 and it looks like using call python configure %configure_flags% allows batch to continue after the python subroutine is finished

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants