Skip to content

crypto: fix warning of ignoring return value - #56527

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:fix-ncrypto-gn
Jan 11, 2025
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:fix-ncrypto-gn

Conversation

@zcbenz

@zcbenz zcbenz commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

CSPRNG is declared with warn_unused_result.

ghost commented Jan 9, 2025

Copy link
Copy Markdown

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@ghost ghost added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Jan 9, 2025
Comment thread deps/ncrypto/ncrypto.cc Resolved
@ghost
ghost force-pushed the fix-ncrypto-gn branch 2 times, most recently from 96f4fb9 to 12e72d6 Compare January 9, 2025 04:16
@ghost ghost added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 11, 2025

ghost commented Jan 11, 2025 •

Copy link
Copy Markdown

@ghost ghost added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jan 11, 2025
@ghost
ghost merged commit 8ca2956 into nodejs:main Jan 11, 2025

ghost commented Jan 11, 2025

Copy link
Copy Markdown

Landed in 8ca2956

@ghost
ghost deleted the fix-ncrypto-gn branch January 11, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants