Repository navigation
Conversation
hvitved
force-pushed
the
rust/call-back-summary-no-suppress
branch
from
November 13, 2026 13:12
80e2945 to
9fae106
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An existing local dataflow test retains stale expectations that will cause failures, and the new regression does not cover captured-value flow through the closure-self heuristic.
2 open issues
What changed in this PR
This PR prevents Rust CodeQL’s heuristic callback summaries and models-as-data summaries from suppressing each other, preserving valid data-flow paths.
Changes:
- Reuse existing summary provenance and exactness for heuristic callback models, retaining defaults when no summary exists.
- Add array-iterator regression cases and update generated flow expectations.
| File | Description |
|---|---|
rust/ql/test/library-tests/dataflow/collections/main.rs |
Adds value-flow cases for for_each and iterator loops. |
rust/ql/test/library-tests/dataflow/collections/inline-flow.expected |
Records new iterator flows and updated model identifiers. |
rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll |
Extracts summary lookup and aligns callback-model provenance and exactness. |
Review effort: Max
hvitved
force-pushed
the
rust/call-back-summary-no-suppress
branch
from
November 13, 2026 13:28
9fae106 to
7792dd0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.